Feature request - Check in approvals

Hot Topic

LoadTest.ThresholdExceeded problem
Two different ID's seems to see the same set of workspaces
creating new process template
No straight forward way to get list of files changed historically?
Bugs while moving files between solutions
VS TFS and VS SDK
Exception in a Web Test with https
Can multiple team projects use the same source control tree?
Language
VSIP Extensibility for Testing Other Languages?

VS Team System

Where to download MSFWinBuild?
uniqe calls per data row
No source control availabe after installing MSSCCI Provider
Can VS2005 Express/Standard/Professional Edition integrate with TFS? HOW?
The report server cannot create the performance counter
Team Explorer - red cross on "documents"-folder
Can't get past the 26204 error
Best Hard Drive configuration for Single Server Team Foundation Server
failed to save the project from vs2003
Next Visual Studio (presumably VS2007, Orcas)

Feature request - Check in approvals

One feature I think could be very useful in the next version of TFS is Check In Approvals. Some users should be configured so that their change set is not fully checked in until it is approved. This is a big help for new team members who are making code changes. It will also be helpful for core framework code where an architect wants to review what code was changed before it is checked in because it affects everyone.

thanks,
Andre

Answer this question

Feature request - Check in approvals

  • Eric Sch.

    Another option is to put the users in a group which has PendChange permission but not Checkin. They can modify the files, shelve them, and then someone else can unshelve, review the change, and checkin. If the other user has "CheckinOther", they can use the command line's "/author" option to list the original user as the actual file modifier. Both users will then be listed in the changeset. See this article for more on the /author option.

    Hope this helps!

    Cheers,
    Adam



  • tie lake synchronized swim team

    Adding a new permissions seems hard to justify given the features we already have.

    - you can add "code reviewer" as a required checkin note. same goes for "architect reviewer" if the core framework is in its own Team Project
    - you can write custom checkin policies that vary the strictness based on path and/or user
    - you can build a system like Gauntlet that forces people to submit shelvesets for review (automated or not) instead of checking in directly
  • Feature request - Check in approvals
Answer this question