Using a Variable inplace of a Textbox name...

Using a Variable inplace of a Textbox name...

• dbough

  Thankyou very much - that helps a lot :)
  
  

• Steven Rosenthal

  Now I dont know the scope of the variable LabelValue and I can see that you are not using option explicit on as you are not having to declare the variable prior to using.

  Private Sub BoxShow(LabelName as string)
  Me.Controls(LabelName).Visible = True
  End Sub
  
  Private Sub ArtifactRarityLabel_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles ArtifactRarityLabel.Click
  LabelValue = "ArtifactRarity"
  BoxShow(LabelValue)
  End Sub

  This way you know your passing the name correctly to the BoxSHow routine. Otherwise you would have to look at the scope of the labelvalue variable. Its definately set in the ArtifactRarityLabel_Click event but is its scope local to this routine and hence in boxshow the labelvalue has no value.

  In the code above you are actually pasing a control name to box show.

  
  

• nikkah

  sorry got caught up with a work thing - just got home, ill try it out tonight(have to go back to work again in a few hours - need some sleep)
  
  

• Russell Mangel

  Verify that the control 'ArtifactRarity' actually exists. First change the code to this

  Private Sub BoxShow()
  Count = +1
  Me.ArtifactRarity.Visible = True
  End Sub
  

  If this works (if the control doesn't exist, it won't even compile), try this

  Private Sub BoxShow()
  Count = +1
  Me.Controls("ArtifactRarity").Visible = True
  End Sub

  If both of these work, you're at least sure you're not dealing with a typing error

  
  
  

• rezord

  That was all good until i came up with an error(go figure!). Alright here it is:
  
  Object reference not set to an instance of an object.
  
  BUT it is... i think
  
  Private Sub BoxShow()
  Count = +1
  Me.Controls(LabelValue).Visible = True
  End Sub
  
  Private Sub ArtifactRarityLabel_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles ArtifactRarityLabel.Click
  LabelValue = "ArtifactRarity"
  BoxShow()
  Count = +1
  End Sub <- this IS running and setting the variable(i checked with break points), and the text box is called exactly that... so now im really confused...
  
  

• Beatriz Costa - MSFT

  Every control on a form is added to the controls collection when the form loads. You can use the controls collection to retrieve a control by it's name. Since all controls are stored in the collection, they items in the collection are of type Control, you can access the Visible property directly.

  Dim ControlName As String

  ControlName = "Textbox1"

  Me.Controls(ControlName).Visible = False

  If you would need a property of the TextBox control, you would have to cast the control first.

  
  
  

• yingfeng

  Sorry i forgot to mention i have this in a Module(so its easier to call)
  
  Module Module1
  Public Count As Integer
  Public LabelValue As String
  End Module
  
  so the variables (should be) are always there... this is getting really confusing - i havnt been able to test today - just finished a 12 hour day at work and im buggered(another tomorrow) so ill crash now and try to work on it tomorrow after work.
  
  PS - for the record being a chef is NOT a good idea - especially a head chef :sigh:
  
  

• DD100

  The code you have 'seems' ok (assuming ArtifactRarity exists), but Spotty has a very good point there. You should add an 'Option Explicit' (Require Variable Declaration) to you module/class. This way, any out-of-scope issues will be caught at compile time.

  Also passing the name of the control to the BoxShow method makes more sense than using a public declared variable.

  
  
  
• Using a Variable inplace of a Textbox name...